New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Arc Support #23

Closed

Schallabajzr opened this issue Oct 26, 2020 · 7 comments

Milestone

Community Release...

Schallabajzr commented Oct 26, 2020

Description

I would like to use https://github.com/FormerLurker/ArcWelderPlugin, but it requires ARC support. Is that something that can be implemented?

Feature Workflow

Ability to process G2 and G3 commands.

Send: G2
Recv: echo:Unknown command: "G2"

The text was updated successfully, but these errors were encountered:

Author

Schallabajzr commented Oct 27, 2020

Tried it. Seems to be working without issue out of the box.

Schallabajzr closed this as completed

Collaborator

Sebazzz commented Oct 27, 2020

Still keeping this open though - we still need to implement this in the default config we ship :)

Sebazzz reopened this

Collaborator

Sebazzz commented Oct 28, 2020

@Nushio or @nickacker you already committed something for this, no?

Collaborator

Nushio commented Oct 28, 2020

I basically turned the feature on. I've tested this a bit (about 8 different prints, from sdcard and octoprint) and so far, nothing's caught fire.

Collaborator

Sebazzz commented Oct 28, 2020 via email

My question was whether you committed it 😁 Met vriendelijke groet, Sebastiaan Dammann

________________________________ Van: Juan Rodriguez <[email protected]> Verzonden: Wednesday, October 28, 2020 10:24:26 PM Aan: CR6Community/Marlin <[email protected]> CC: Sebastiaan Dammann <[email protected]>; State change <[email protected]> Onderwerp: Re: [CR6Community/Marlin] [FR] Arc Support (#23) I basically turned the feature on. I've tested this a bit (about 8 different prints, from sdcard and octoprint) and so far, nothing's caught fire. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCR6Community%2FMarlin%2Fissues%2F23%23issuecomment-718217352&data=04%7C01%7C%7C05819dea8d914536853a08d87b87d9a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637395170678411676%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZeGBtOb8H6Gy%2BSrRcgTm%2F6tDrSlwbC3TLe%2BDZYnwG3E%3D&reserved=0>, or unsubscribe<https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAK4FMNZMYOBLLGZPAUCBU3SNCDYVANCNFSM4TABD7HQ&data=04%7C01%7C%7C05819dea8d914536853a08d87b87d9a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637395170678411676%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Itz4gGxbQjzhzA6wTR2k8wDV7DAvjqNKCSKmlB74rGw%3D&reserved=0>.

Collaborator

Sebazzz commented Oct 29, 2020

Fixed on main branch and extui branch.

Sebazzz added this to the Community Release 4 alpha milestone

Collaborator

Sebazzz commented Nov 1, 2020

Ready for next release.

Sebazzz closed this as completed

Sebazzz mentioned this issue

Draft release notes for community release 4 alpha #36

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment