Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #72 #73

Merged
merged 10 commits into from
Oct 5, 2020
Merged

Resolves issue #72 #73

merged 10 commits into from
Oct 5, 2020

Conversation

a3dho3yn
Copy link
Contributor

This PR will:

  • prevent trimming whitespaces from the beginning of lines
  • prevent considering first element of an entry as TTL
  • consider both null and empty domain-name as not stated

Closes #72

@a3dho3yn
Copy link
Contributor Author

The Parser::processLine sets TTL for all records equal to the default value. Then the null === $this->currentResourceRecord->getTtl() criteria on Parser::populateWithLastStated will be always false and the parser will never uses the last stated TTL (which is the desired behavior based on RFC1053).

Omitted class and TTL values are default to the last explicitly stated values.

This is why ReverseRecordTest::testParseReverseRecordFile fails.

@a3dho3yn
Copy link
Contributor Author

@samuelwilliams any comments?

@fshafiee
Copy link

fshafiee commented Aug 3, 2020

That'd be nice if we could see this merged to the main repo.

@a3dho3yn
Copy link
Contributor Author

a3dho3yn commented Oct 3, 2020

@samuelwilliams @srsbiz @skirmis is there any problem with this PR?

@samuelwilliams samuelwilliams merged commit 82ff4e0 into Badcow:master Oct 5, 2020
@a3dho3yn a3dho3yn deleted the fix/issue72 branch October 5, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid TTL and name when record name is numeric
3 participants