removed strict hostname validator for Question::setName #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead just validate the domain name is valid. This allows us to use domains like `_sip._tcp.example.com` in Questions which would otherwise fail because of the Question::setName()'s reliance on the validator. Reference to a similar case with resource records: Badcow@af12eb9 validate Question::setName to allow for special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead just validate the domain name is valid. This allows us to use domains like
_sip._tcp.example.comin Questions which would otherwise fail because of the Question::setName()'s reliance on the validator.This is useful when constructing a question to later pass to an actual DNS query via the
toWire()method on the message.Reference to a similar case with resource records: af12eb9