Fix to prevent double stripping of backslashes. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SloEddy
force-pushed
the
fix-double-escapes
branch
from
79978cd to
b7f1880
Compare
|
would be good to get this in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelwilliams parsing a bind file like below currently triggers a unicode conversion to occur, stripslashes appears to be the problem but when reading fromText the handleTxt method already strips the necessary back slashes, re-stripping them in setText is then a problem
Even if it's rather unlikely \010 will ever be needed in a TXT record the parser shouldn't convert things to unicode if the double escape sequence followed by numbers does occur.