feat: add svc export trackability #1061
Open
+306
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
force-pushed
the
svcExportTrackability
branch
5 times, most recently
from
87efd16 to
e49aff2
Compare
|
upgrade controller runtime changes are addressed in #1067 (will need to be merged before this) |
britaniar
force-pushed
the
svcExportTrackability
branch
from
9b3574b to
593b6b3
Compare
britaniar
force-pushed
the
svcExportTrackability
branch
from
593b6b3 to
c47b06c
Compare
zhiying-lin
reviewed
Mar 6, 2025
zhiying-lin
reviewed
Mar 7, 2025
britaniar
force-pushed
the
svcExportTrackability
branch
from
74d71eb to
6b43ca2
Compare
zhiying-lin
reviewed
Mar 12, 2025
|
|
||
| weight, err := objectmeta.ExtractWeightFromServiceExport(&svcExport) | ||
| if err != nil { | ||
| klog.V(2).InfoS("ServiceExport has invalid weight", "serviceExport", svcExportObj, "error", err) |
There was a problem hiding this comment.
Suggested change
| klog.V(2).InfoS("ServiceExport has invalid weight", "serviceExport", svcExportObj, "error", err) | |
| klog.Errorf(err, "ServiceExport has invalid weight", "serviceExport", svcExportObj) |
| weight, err := objectmeta.ExtractWeightFromServiceExport(&svcExport) | ||
| if err != nil { | ||
| klog.V(2).InfoS("ServiceExport has invalid weight", "serviceExport", svcExportObj, "error", err) | ||
| return ManifestProcessingAvailabilityResultTypeFailed, err |
There was a problem hiding this comment.
Suggested change
| return ManifestProcessingAvailabilityResultTypeFailed, err | |
| return ManifestProcessingAvailabilityResultTypeNotYetAvailable, err |
ManifestProcessingAvailabilityResultTypeFailed means the checking the availability itself is failed.
| return ManifestProcessingAvailabilityResultTypeNotYetAvailable, nil | ||
| } | ||
|
|
||
| weight := svcExport.Annotations[objectmeta.ServiceExportAnnotationWeight] | ||
| if weight != "0" { | ||
| weight, err := objectmeta.ExtractWeightFromServiceExport(&svcExport) |
There was a problem hiding this comment.
could you please add a comment here to indicate why we check the annotation here?
eg,
"Updating the annotation won't change the object generation, so the current status is not reliable and we validate the annotation again here."
| Name: "test-svcExport", | ||
| Namespace: nsName, | ||
| Annotations: map[string]string{}, | ||
| Generation: 3, | ||
| }, | ||
| } | ||
|
|
||
| testCases := []struct { |
There was a problem hiding this comment.
add a test if the weight annotation is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer