fix: address an issue in the rollout controller where bindings might not receive status refresh after binding spec changes #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| // cluster, upgrading to a newer resource/override snapshot, or removing) but are blocked by | ||
| // the rollout strategy. | ||
| // | ||
| // Update the status first, so that if the rolling out (updateBindings func) fails in the |
There was a problem hiding this comment.
what does this comment mean?
There was a problem hiding this comment.
Hi Ryan! This (Update the status first...) was the original comment I believe.
|
Per offline discussions, will temporarily drop the change that populates the |
ryanzhang-oss
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes an issue in the rollout controller where bindings might not receive status refresh after binding spec changes.
Specifically, when
a) a
Boundbinding with up to date resource/override snapshot; orb) an
Unscheduledbinding that has not been deleted yethas its spec changed (e.g., apply strategy update), rollout controller will stop processing them and such bindings will no longer have fresh
RolloutStartedcondition added to their status. As a result, work generator will refuse to process these bindings and the system will be stuck.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
N/A