-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove uncached reader in eviction controller #1044
base: main
Are you sure you want to change the base?
Conversation
Hi Arvind! To summarize some of the approaches we have gone through (specific to the test part): a) use the
b) use the
|
1 similar comment
Hi Arvind! To summarize some of the approaches we have gone through (specific to the test part): a) use the
b) use the
|
48386c2
to
e948d7e
Compare
e948d7e
to
8cd9ee9
Compare
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Removed the uncached reader from eviction controller, was originally added to account for cache miss when attempting to get PDB in the controller, E2Es were failing
Steps taken to remedy issue,
These steps aim to optimistically ensure that the E2Es are retried even on a cache and hopefully the cache is populated on the retry to successfully get PDB and block eviction