New issue

Jump to bottom

Simplify resource slice controller #302

Merged

jveski merged 18 commits into main from simplify-resource-slice-controller

Mar 17, 2025

+944 −1,714

Collaborator

jveski commented Mar 14, 2025

There is a ton of history around the resource slice cleanup logic and it's gotten quite complicated.

Create a new catch-all resource slice controller
Merge in the existing slice cleanup controller
Merge in the self healing controller
Merge in the slice aggregation controller
Significantly simplify the logic of the consolidated controllers

Jordan Olshevski added 10 commits

March 14, 2025 11:46


          Flatten

fa77d40


          Move slice cleanup controller

ceb7e5f


          Rename cleanup controller

72a4bd1


          Simplify slice GC

fb0c892


          Remove finalizer from full resource, not partial/cached representation

97b56f4


          Test coverage for requeue

d2a75cf


          Actually, the finalizer is necessary

cf0e3af


          Add integration tests around both controllers

2ccfafc


          Event filters

6b6ae18


          Fix envtest test by removing dependency on k8s GC

102b486

jveski enabled auto-merge (squash)

March 14, 2025 17:35

AYM1607 reviewed

View reviewed changes

api/v1/resourceslice.go Show resolved Hide resolved

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Show resolved Hide resolved

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Outdated Show resolved Hide resolved

Jordan Olshevski added 2 commits

March 14, 2025 20:35


          Add note about why the separate deletion controller

2b4cbe7


          Remove unnecessary 404 check

21d3914

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Outdated Show resolved Hide resolved

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Show resolved Hide resolved

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Show resolved Hide resolved


          Flip logic for readers

648db2b

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Outdated Show resolved Hide resolved

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slice.go Outdated Show resolved Hide resolved

Jordan Olshevski added 2 commits

March 14, 2025 20:59


          Log in an impossible case

3f92c99


          Correct comment

fb9b60b

AYM1607 reviewed

View reviewed changes

internal/controllers/resourceslice/slicecleanup.go Outdated Show resolved Hide resolved

Jordan Olshevski added 3 commits

March 17, 2025 16:01


          Revert "Log in an impossible case"

2f11c78

This reverts commit 3f92c99.


          Log latency when len(slices) == 0

95cbca6


          GC slices when in-flight synthesis changes

7aebaaf

AYM1607 approved these changes

View reviewed changes

Contributor

AYM1607 left a comment

LGTM

jveski merged commit 9c41537 into main

29 checks passed

jveski deleted the simplify-resource-slice-controller branch

March 17, 2025 17:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet