-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock reconciliation during synthesis #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jveski
commented
Mar 4, 2025
jveski
commented
Mar 4, 2025
jveski
commented
Mar 4, 2025
jveski
commented
Mar 4, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
AYM1607
reviewed
Mar 5, 2025
This reverts commit c4c0b71.
AYM1607
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229.
Since Eno only currently retains two syntheses, it isn't possible to (correctly) reconcile resources while synthesis is in-progress. So configuration might drift in cases where synthesis is slow.
It isn't a huge problem currently since synthesis is fast, but keeping a third synthesis ends up significantly simplifying the synthesis controller, which I'm working on property-based tests and refactoring for currently.
This change adds an "in flight" synthesis that is swapped into the existing "current" slot when synthesis is complete. I tried not to touch unrelated code - the diff mostly just swaps synthesis references, with a few exceptions (I'll leave PR comments to clarify).
Backcompat
CurrentSynthesis.Synthesized != nil
are unaffected - this is still the terminal stateCurrentSynthesis == nil
are unaffected since the new code will be used for synthesisCurrentSynthesis != nil && CurrentSynthesis.Synthesized == nil
(a.k.a. in-flight synthesis) will converge eventually because the scheduling controller considers(CurrentSynthesis.Synthesized == nil) == (CurrentSynthesis == nil)