Remove bottleneck in reconciliation controller #289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the default controller work queue rate limiter has a shared token bucket of 10 RPS (with some reasonable burst) that applies to all requeues. Since the reconciliation controller can't/doesn't watch the resources it writes, it relies on requeues to form its feedback loop, which means when the loop ticks into the second iteration of any resource (typically the status update) it will wait a few dozen milliseconds.
This also fixes a couple of other small nits surrounding client-side rate limiting.