Add test for Eno->Helm migration #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really hope no one uses this lol |
AYM1607
reviewed
Jul 23, 2024
| err = downstream.Get(ctx, client.ObjectKeyFromObject(obj), obj) | ||
| uid = string(obj.GetUID()) | ||
| return err == nil | ||
| }) |
There was a problem hiding this comment.
For the sake of completeness, should we add a step here to delete the comp with orphaning set?
There was a problem hiding this comment.
We cover that in the other helm test case, so I'd rather avoid it here. These tests are just so dang long already
AYM1607
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to make sure Helm releases can adopt resources created by Eno (of course hopefully no one ever uses this 🙃 )