-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(programming-language-support): Add dooku.nvim #503
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Maybe it would be better to create the directory |
@Zeioth Next time please read the Contributing.md. :) |
Removed empty opts = {}.
@Zeioth You misunderstood what I said. That config = function(_,opts)..... stuff should not be there, just the opts. Like this: |
Also, I think this plugin should be under programming-tools or something. Comment doesn't seem to fit it's category. |
Ok @Uzaaft I'm moving it to |
Done, please let me know if you want any other change. |
I still don't see the opts table there. Here, I'll give you the code: return {
{
"Zeioth/dooku.nvim",
cmd = { "DookuGenerate", "DookuOpen", "DookuAutoSetup" },
opts = {}
}
} |
@Uzaaft thank you for your patience, I've tested the code, and now I see when passing opts = {}, the config line is not necessary. |
Sweet. :) |
Alright. I just double checked before I pressed the merge button. Sorry about all the back and forth @Zeioth. return {
{
"Zeioth/dooku.nvim",
cmd = { "DookuGenerate", "DookuOpen", "DookuAutoSetup" },
opts = {},
}
} We'll merge if this is fixed. Again, sorry about it @Zeioth |
lua/astrocommunity/programming-language-support/dooku-nvim/init.lua
Outdated
Show resolved
Hide resolved
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Co-authored-by: Uzair Aftab <[email protected]>
Adds dooku.nvim under
/comment