Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(programming-language-support): Add dooku.nvim #503

Merged
merged 7 commits into from
Aug 5, 2023
Merged

feat(programming-language-support): Add dooku.nvim #503

merged 7 commits into from
Aug 5, 2023

Conversation

Zeioth
Copy link
Contributor

@Zeioth Zeioth commented Aug 5, 2023

Adds dooku.nvim under /comment

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Zeioth
Copy link
Contributor Author

Zeioth commented Aug 5, 2023

Maybe it would be better to create the directory code-documentation instead of adding it to comment, but at the moment it would only have dooku.nvim, and I didn't want to add more complexity to the repo.

@Uzaaft Uzaaft changed the title feat(dooku.nvim) Gen and open html documentation. feat(comment): Add dooku.nvim Aug 5, 2023
@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

@Zeioth Next time please read the Contributing.md. :)

Removed empty opts = {}.
@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

@Zeioth You misunderstood what I said. That config = function(_,opts)..... stuff should not be there, just the opts. Like this:
image

@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

Also, I think this plugin should be under programming-tools or something. Comment doesn't seem to fit it's category.

@Zeioth
Copy link
Contributor Author

Zeioth commented Aug 5, 2023

Ok @Uzaaft I'm moving it to programming-tools. But the config line is necessary. The plugin doesn't do that for you atm.

@Zeioth
Copy link
Contributor Author

Zeioth commented Aug 5, 2023

Done, please let me know if you want any other change.

@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

I still don't see the opts table there.

Here, I'll give you the code:

return {
  {
    "Zeioth/dooku.nvim",
    cmd = { "DookuGenerate", "DookuOpen", "DookuAutoSetup" },
	opts = {}
  }
}

@Zeioth
Copy link
Contributor Author

Zeioth commented Aug 5, 2023

@Uzaaft thank you for your patience, I've tested the code, and now I see when passing opts = {}, the config line is not necessary.

@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

@Uzaaft thank you for your patience, I've tested the code, and now I see when passing opts = {}, the config line is not necessary.

Sweet. :)

@Uzaaft Uzaaft changed the title feat(comment): Add dooku.nvim feat(programming-tools): Add dooku.nvim Aug 5, 2023
@Uzaaft
Copy link
Member

Uzaaft commented Aug 5, 2023

Alright. I just double checked before I pressed the merge button. Sorry about all the back and forth @Zeioth.
Stylua is complaining about a missing ,. Fixed down below. The group we should use is programming-language-support

return {
  {
    "Zeioth/dooku.nvim",
    cmd = { "DookuGenerate", "DookuOpen", "DookuAutoSetup" },
	opts = {},
  }
}

We'll merge if this is fixed. Again, sorry about it @Zeioth

@Zeioth
Copy link
Contributor Author

Zeioth commented Aug 5, 2023

@Uzaaft woop, miss understanding on my side. changes applied on 3bcaab8

  • comma added after opts = {},
  • moved to directory programming-language-support

@Uzaaft Uzaaft changed the title feat(programming-tools): Add dooku.nvim feat(programming-language-support): Add dooku.nvim Aug 5, 2023
@Uzaaft Uzaaft self-requested a review August 5, 2023 17:18
@Uzaaft Uzaaft merged commit 6deb350 into AstroNvim:main Aug 5, 2023
Uzaaft added a commit that referenced this pull request Aug 5, 2023
Uzaaft added a commit that referenced this pull request Aug 6, 2023
Uzaaft added a commit that referenced this pull request Aug 6, 2023
Uzaaft added a commit that referenced this pull request Aug 6, 2023
Uzaaft added a commit that referenced this pull request Aug 9, 2023
Uzaaft added a commit that referenced this pull request Aug 9, 2023
Uzaaft added a commit that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants