-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go)!: move from go.nvim
to gopher.nvim
#1059
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This has covered some missing points in #1060 so it can be closed in favor of this PR. The README should definitely be reverted as well though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing shit
The readme is outdated since we've removed gofumpt and added gotests |
Co-authored-by: rami3l <[email protected]>
📑 Description
This moves away from
go.nvim
as it is very error prone and also very heavy. This also uses Mason for go dependencies by default rather than the synchronous and slow dependency installation command.ℹ Additional Information