Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go)!: move from go.nvim to gopher.nvim #1059

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat(go)!: move from go.nvim to gopher.nvim #1059

merged 1 commit into from
Jun 21, 2024

Conversation

mehalter
Copy link
Member

📑 Description

This moves away from go.nvim as it is very error prone and also very heavy. This also uses Mason for go dependencies by default rather than the synchronous and slow dependency installation command.

ℹ Additional Information

Copy link

github-actions bot commented Jun 20, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Contributor

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This has covered some missing points in #1060 so it can be closed in favor of this PR. The README should definitely be reverted as well though.

Uzaaft
Uzaaft previously approved these changes Jun 21, 2024
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing shit

@Uzaaft Uzaaft dismissed their stale review June 21, 2024 13:06

readme outdated

@Uzaaft
Copy link
Member

Uzaaft commented Jun 21, 2024

The readme is outdated since we've removed gofumpt and added gotests

@mehalter mehalter merged commit 5adae48 into main Jun 21, 2024
12 checks passed
@mehalter mehalter deleted the gopher branch June 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants