-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use single precision for dtoa with f32 #2908
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Haha, I just read this line in the Kotlin sources for their original implementation:
And then it looks like just last week, @skuzmich gave it the 32-bit precision support, for the same reasons. Seems fair to add it back here too! (Thanks @skuzmich!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If @MaxGraey says it looks good, we should merge it. |
Fixes #2873
Changes proposed in this pull request:
Adjusts
dtoa
anddtoa_buffered
to accept eitherf32
orf64
. Implementation details borrowed from Kotlin.