Added aura for item + private fork #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 15% ranged damage increase aura on athenian arrows. As well as pushing changes to private fork now.
|
Did you really need to fork the entire repo just to make that one commit? |
|
Well you don't fork part of a repo 😄 I think direct commits & symblinks are better tho, but whatever works for you guys |
|
My work flow is work off a fork then make pull requests, but I can do direct commits as well. I'd prefer for now doing the former, and have someone take a quick look for any problems. Then later I'll do direct. That merge commit is certainly horrible to look at though :( |
|
Maybe working off a branch would be better. |
|
Just stay on a branch on Aleteh's repo. |
|
There are some conflicts, but i guess it has something to do with the reorganizing of items i did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little formatting fix, new aura for item, pulling from private fork and a few debug messages.