Add Additional Image MIME Types, Dynamic Per OS #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any plans on continuing work on this PR? |
|
@maciej-letgo Yes, it just needs test updates. I just need to be less busy to finish it up. |
ryndinol
pushed a commit
to ryndinol/AlamofireImage
that referenced
this pull request
Apr 26, 2021
* Update project for Xcode 12. * Fix Carthage usage. * Update formatting. * Make default MIME types dynamic for OS versions. * Update GitHub CI. * Update iOS tests, formatting. * Disable WebP on tvOS. * Add newline. * Fix test for lower os versions. * Conditionalize WebP test. * Use Big Sur for macOS tests. * Guard at runtime. * Remove unnecessary availability. * Update to Xcode 12.4. * Update CI to 12.4. * Fix tvOS version. * Remove unnecessary guard.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#428 #47
Goals ⚽
This PR updates our default MIME types to be properly dynamic by OS version. It also adds support for JPEG2000 on all OSes, HEIC and HEIF on 2017 OSes, and WebP on macOS 11 and iOS 14 (doesn't seem to work on tvOS 14).
Implementation Details 🚧
Simply constructs the default accept types dynamically.
Testing Details 🔍
Tests updated for additional MIME types and image type support.