Use accept header that is sorted for default header. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryndinol
pushed a commit
to ryndinol/AlamofireImage
that referenced
this pull request
Apr 26, 2021
* use accept header that is sorted * fix tests * fix UIButtonTest for this changes Co-authored-by: Junichiro Kasuya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
I'm building an image storage SaaS and using a CDN.
One of my clients is using this library and the AcceptHeader changes every time.
So the CDN cache doesn't work effectively.
Implementation Details 🚧
I change the order of the Accept Header to sort before return it.
Testing Details 🔍
I've modified it to test the sorted accept header.
Please let me know what kind of test I should do if needed other cases.