Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 5.1 #413

Merged
merged 8 commits into from
Apr 6, 2020
Merged

Update to Swift 5.1 #413

merged 8 commits into from
Apr 6, 2020

Conversation

jshier
Copy link
Contributor

@jshier jshier commented Apr 5, 2020

Goals ⚽

This PR updates to require Swift 5.1 to match Alamofire.

Implementation Details 🚧

swiftformat was run in 5.1 mode and a few things were updated, like the CI configuration.

@jshier jshier requested a review from cnoon April 5, 2020 20:51
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jshier...just one small nit.

README.md Outdated
@@ -73,7 +73,7 @@ Once you have your Swift package set up, adding AlamofireImage as a dependency i

```swift
dependencies: [
.package(url: "https://github.com/Alamofire/AlamofireImage.git", from: "4.0")
.package(url: "https://github.com/Alamofire/AlamofireImage.git", .upToNextMajor(from: "5.1.0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost the indent.

@jshier jshier merged commit 503d66f into master Apr 6, 2020
@jshier jshier deleted the swift-5.1 branch April 6, 2020 01:49
@jshier jshier added this to the 4.1.0 milestone Apr 6, 2020
ryndinol pushed a commit to ryndinol/AlamofireImage that referenced this pull request Apr 26, 2021
* Update to Swift 5.1, update testing to Xcode 11.4.

* Remove Catalyst testing, as Carthage doesn’t support it.

* Sign to run locally for testing.

* Update README.

* Update package file.

* Apply Xcode recommended changes.

* Replace indent.

* Use correct version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants