Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SwiftFormat #396

Merged
merged 4 commits into from
Feb 23, 2020
Merged

Add SwiftFormat #396

merged 4 commits into from
Feb 23, 2020

Conversation

jshier
Copy link
Contributor

@jshier jshier commented Feb 23, 2020

Goals ⚽

This PR adds SwiftFormat with a style similar to existing style. it also updates our GitHub action for Xcode 11.3.

cnoon
cnoon approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me! I only had one comment about how multi-line functions get formatted at the end.

@jshier jshier merged commit 96f291f into master Feb 23, 2020
@jshier jshier deleted the feature/swift-format branch February 23, 2020 06:51
@cnoon cnoon self-assigned this Feb 23, 2020
@cnoon cnoon added this to the 4.0.0 milestone Feb 23, 2020
ryndinol pushed a commit to ryndinol/AlamofireImage that referenced this pull request Apr 26, 2021
@jshier @ryndinol
Add SwiftFormat (Alamofire#396)
4606722 
* Add SwiftFormat, apply it.

* Remove whitespace cleanup phase.

* Update GitHub action.

* Match Alamofire style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnoon cnoon cnoon approved these changes

Assignees

@cnoon cnoon

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jshier @cnoon