Tests for throwing URLRequestConvertible #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybridcattt
force-pushed
the
throwing_url_convertible_4_0
branch
from
8ced6a7 to
d6012a2
Compare
cnoon
pushed a commit
that referenced
this pull request
Feb 23, 2020
cnoon
pushed a commit
that referenced
this pull request
Feb 23, 2020
ryndinol
pushed a commit
to ryndinol/AlamofireImage
that referenced
this pull request
Apr 26, 2021
ryndinol
pushed a commit
to ryndinol/AlamofireImage
that referenced
this pull request
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Unit tests for #241
Goals ⚽
Ensure the library correctly supports throwing
URLRequestConvertiblerequestsImplementation Details 🚧
I've started fixing #241 but then noticed that a fix is already present on master. I already added the tests at that point, so hope these are useful still.
ImageDownloader,UIButtonandUIImageViewextensionsImageDownloaderto make it easier to understand and make it safer - preventing variable shadowing that can confuse the reader.Testing Details 🔍
The PR mainly contains new tests for pre-existing functionality, and the minor refactoring in
ImageDownloaderis covered by existing tests which pass.There are couple of failing tests which seem to be failing on master too.