Wrong signature when there is no commands #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,15 +37,23 @@ public function __construct($server, $secret, $original, $commands) | |||
| */ | |||
| public function stringify($server, $secret, $original, $commands) | |||
| { | |||
| $commandPath = implode('/', $commands); | |||
| $signature = $secret ? self::sign("$commandPath/$original", $secret) : 'unsafe'; | |||
| if(count($commands) > 0) | |||
There was a problem hiding this comment.
Could you reformat this as PSR-2?
|
Thanks! Could you please add a test case? :-) |
added 2 commits
December 12, 2014 21:35
|
Done ;-) (Change test case) |
|
Thanks very much! :-) |
harto
added a commit
that referenced
this pull request
Dec 12, 2014
Wrong signature when there is no commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature is wrong when we try to create an URL without any commands, for proxying reasons for example:
$thumbnailUrlFactory = Thumbor\Url\BuilderFactory::construct('https://DOMAINE', $secret);
echo $thumbnailUrlFactory
->url('http://images.example.com/llamas.jpg')
->build()
->toString();
Result in:
https://DOMAINE/w_ENl4PO7AIjS4x33fmoAQDI-kQ=//http://images.example.com/llamas.jpg
which is wrong and must be:
https://DOMAINE/I5ejYVaMsVMGWaxaVKrgSw3UoP0=/http://images.example.com/llamas.jpg