Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio-postgres v0.7.9 breaks load_config #1

Closed
ryzhyk opened this issue Aug 24, 2023 · 4 comments
Closed

tokio-postgres v0.7.9 breaks load_config #1

ryzhyk opened this issue Aug 24, 2023 · 4 comments

Comments

@ryzhyk
Copy link

ryzhyk commented Aug 24, 2023

Due to this issue, load_config(None) now ignores the PGUSER env variable and sets Config::user to the current OS user instead.
ryzhyk pushed a commit to feldera/feldera that referenced this issue Aug 24, 2023
Work around a breaking change in tokio-postgres.
aeb823b 
Workaround for

https: //github.com/3liz/pg-event-server/issues/1, which is caused by
https: //github.com/sfackler/rust-postgres/issues/1062
Signed-off-by: Leonid Ryzhyk <[email protected]>
ryzhyk pushed a commit to feldera/feldera that referenced this issue Aug 24, 2023
@ryzhyk
Work around a breaking change in tokio-postgres.
df9a782 
Workaround for

https: //github.com/3liz/pg-event-server/issues/1, which is caused by
https: //github.com/sfackler/rust-postgres/issues/1062
Signed-off-by: Leonid Ryzhyk <[email protected]>
@dmarteau
Copy link
Member

@ryzhyk Thanks for reporting this !

I updated the dependencies and tests are indeed broken with tokio-postgres v0.7.9.
Working on a workaround...

@dmarteau
Copy link
Member

They have released v0.7.10 that fix the problem, I will just wait if they are going to yank 0.7.9 before doing anything.

dmarteau added a commit that referenced this issue Aug 26, 2023
@dmarteau
Add warning notice about tokio-postgres 0.7.9
2b3d9a0 
    - See #1
@dmarteau
Copy link
Member

IMHO a simple warning notice about not using tokio-postgres 1.7.9 should be ok:

  • tokio-postgres 1.7.10 is 1.7.9 without the breaking change so 1.7.10 can be used instead without problems.
  • I don't want requiring 1.7.10+ since lower versions are still compatible.

@dmarteau
Copy link
Member

Tested with 1.7.10 and all is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmarteau @ryzhyk