This repository was archived by the owner on Nov 20, 2018. It is now read-only.
this seems to be sufficient to update the documents #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well if ember is updating things itself anyway (really??) then it definitely needs a rework. I got totally blown off track yesterday, so no time to play with it, but I'll put up a proper PR this weekend as I have some time. bad ember |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on the diff-match-patch algorithm, but then I realised the documents were updating anyway due to the fact that when ember receives a message from pusher, it reloaded the documents anyway from the server.
At this point, the ideal solution would still be a proper diff-patch (or operational transform), but this PR proposes a temporary solution that 1) simplifies the code a bit and 2) keeps the size of the pusher messages constant (only the doc id is transmitted).