Support Newest Manylinux Version for dependencies #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zappa was hard coded to only allow Manylinux 1, 2010, and 2014. Manylinux 2_24 is getting more traction, so dependencies are becoming incompatible with Zappa over time. More information on new Manylinux versions can be found here - https://github.com/pypa/manylinux An important example is Cryptography, where version 3.4.7 is the last one to support old-format linux wheels. https://pypi.org/project/cryptography/3.4.7/#files vs newest: https://pypi.org/project/cryptography/#files Tested on my env to make sure that manylinux 2_24 wheels would work without issue in Lambda
hellno
approved these changes
Nov 22, 2021
|
Is there a reason it things the coverage decreased for some python version, but stayed the same for overall coverage and py3.7? |
|
We need to fix the flaky coverage tests separately, it's not related to this PR. |
|
Updated from master to test new coveralls threshold, seems to work 👍🏼 |
|
Thanks for the PR @phil-airship, I went ahead and merged it |
phil-airship
added a commit
to phil-airship/Zappa
that referenced
this pull request
May 15, 2023
Had added support for Manylinux 2_24 in 2021: zappa#1083 But that version is EoL and Python Cryptography has moved to Manylinux 2_28. Updating to support while maintaining backwards compatibility. Tested on Lambda an encountered no issues
Ian288
pushed a commit
to tackle-io/Zappa
that referenced
this pull request
Jul 11, 2023
* Support Newest Manylinux Version for dependencies Zappa was hard coded to only allow Manylinux 1, 2010, and 2014. Manylinux 2_24 is getting more traction, so dependencies are becoming incompatible with Zappa over time. More information on new Manylinux versions can be found here - https://github.com/pypa/manylinux An important example is Cryptography, where version 3.4.7 is the last one to support old-format linux wheels. https://pypi.org/project/cryptography/3.4.7/#files vs newest: https://pypi.org/project/cryptography/#files Tested on my env to make sure that manylinux 2_24 wheels would work without issue in Lambda * Update core.py Co-authored-by: hellno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zappa was hard coded to only allow Manylinux 1, 2010, and 2014.
Manylinux 2_24 is getting more traction, so dependencies are becoming incompatible with Zappa over time.
More information on new Manylinux versions can be found here - https://github.com/pypa/manylinux
An important example is Cryptography, where version 3.4.7 is the last one to support old-format linux wheels.
https://pypi.org/project/cryptography/3.4.7/#files
vs newest:
https://pypi.org/project/cryptography/#files
Tested on my env to make sure that manylinux 2_24 wheels would work without issue in Lambda