Added the Portuguese language and fixed typos on POT and pt_BR #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvt
requested changes
Dec 10, 2016
There was a problem hiding this comment.
Thank you for fixing typo, but to do that you also need to fix the source text accordingly or the translation system won't be able to find the translated text.
feikname
requested changes
Dec 10, 2016
| @@ -544,7 +544,7 @@ msgstr "Ver." | |||
| #: ../../Scripts/Gui/MainScreen.as:515 ../../Scripts/Gui/MainScreen.as:529 | |||
| msgctxt "MainScreen" | |||
| msgid "Loc." | |||
| msgstr "Loc." | |||
| msgstr "Ling." | |||
There was a problem hiding this comment.
@DarkDracoon "Loc." represents the physical location of the server, not the language.
Also, I am the translator of the pt_br language, thanks for the fixes. Submit a pull request whenever you find something that can be improved :)
yvt
approved these changes
Dec 10, 2016
|
Sorry for that. Just corrected the source text and let the Loc. be as it was. |
feikname
approved these changes
Dec 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm requesting this pull in order of adding support to Portuguese language and fixing typos found on POT - base language (which caused to change on the other languages) and pt_BR.
Additionally, on the JSON that identifies the languages, I've changed "Portuguese" to "Portuguese (Brazil)" and created the pt_PT.json to identify the Portuguese (Portugal) language.
PS: There might be things that can be slightly equal between Portuguese (Portugal) and Portuguese (Brazil), since both languages are based from the same language, only the regional changes.