Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mumble support #413

Merged
merged 4 commits into from
Aug 12, 2016
Merged

Add mumble support #413

merged 4 commits into from
Aug 12, 2016

Conversation

louwaque
Copy link
Contributor

@louwaque louwaque commented Aug 3, 2016

Works on linux and not tested on windows

@@ -0,0 +1,41 @@
#include "Player.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put a header guard at the beginning of the header:

#pragma once

...

And wrapping the classes into the spades namespace for consistency is probably a good idea.

@yvt yvt merged commit 004ca97 into yvt:master Aug 12, 2016
@yvt
Copy link
Owner

yvt commented Aug 12, 2016

Cool! Thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants