fix: stack overflow in table.concat function #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Stack Overflow in table.concat Function
This PR fixes a stack overflow issue in the
table.concat
function when working with large tables.Problem
The previous implementation of
tableConcat
pushed all values and separators onto the Lua stack before concatenating them. This approach caused stack overflow errors when dealing with large tables.Solution
This fix changes the implementation to build the result string incrementally rather than pushing all values onto the stack first. Instead of accumulating items on the stack, we now:
Testing
The fix has been verified with large tables that previously caused stack overflow. For example, this test case now works correctly:
This example would previously fail with a stack overflow error but now executes successfully.