Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar's elevation not customisable #9

Closed
KamilSztandur opened this issue Jul 14, 2023 · 3 comments · Fixed by #44
Closed

Top bar's elevation not customisable #9

KamilSztandur opened this issue Jul 14, 2023 · 3 comments · Fixed by #44
Assignees
Labels
ThemeExtensions Theme extensions epic

Comments

@KamilSztandur
Copy link

KamilSztandur commented Jul 14, 2023

Bottom sheet top bar elevetion's color is hardcoded and ruins dark theme for my app. Please, add possibility to directly customise it's thickness, color or being able to disable it.

class WoltModalSheetTopBar extends StatelessWidget {
  final double topBarHeight;
  final ValueListenable<double> currentScrollPositionListenable;
  final GlobalKey titleKey;
  final double topBarTranslationYAmountInPx;
  final WoltModalSheetPage page;

  const WoltModalSheetTopBar({
    required this.page,
    required this.topBarHeight,
    required this.currentScrollPositionListenable,
    required this.titleKey,
    required this.topBarTranslationYAmountInPx,
    Key? key,
  }) : super(key: key);

  // TODO: get this information from ThemeData extensions
  static const _elevation = 1.0;
  static const _elevationColor = Color(0xFFE4E4E4);
  static const _topBarTitleTranslationYAmount = 8.0;
@KamilSztandur KamilSztandur changed the title Bottom sheet header's elevation not customizable Top bar's elevation not customizable Jul 14, 2023
@KamilSztandur KamilSztandur changed the title Top bar's elevation not customizable Top bar's elevation not customisable Jul 14, 2023
@ulusoyca
Copy link
Collaborator

Yes, this is a TODO. We are planning to use ThemeExtensions. ping @rydmike @TahaTesser

@ulusoyca ulusoyca added the enhancement New feature or request label Jul 21, 2023
@ulusoyca ulusoyca moved this to 🔖 Backlog in WoltModalSheet Backlog Jul 28, 2023
@ulusoyca ulusoyca added this to the ThemeExtensions milestone Jul 28, 2023
@ulusoyca ulusoyca self-assigned this Jul 28, 2023
@ulusoyca ulusoyca added ThemeExtensions Theme extensions epic and removed enhancement New feature or request labels Jul 28, 2023
@ulusoyca ulusoyca moved this from 🔖 Backlog to 🏁 Ready to implement in WoltModalSheet Backlog Aug 18, 2023
@ulusoyca ulusoyca moved this from 🏁 Ready to implement to 👀 In Progress in WoltModalSheet Backlog Aug 18, 2023
@ulusoyca ulusoyca moved this from 👀 In Progress to 💬 In review in WoltModalSheet Backlog Aug 19, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@TahaTesser
Copy link
Collaborator

cc: @ulusoyca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ThemeExtensions Theme extensions epic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants