Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Flexibility with Custom Modal Types #231

Closed
7 tasks done
ulusoyca opened this issue Jun 9, 2024 · 1 comment
Closed
7 tasks done

Enhanced Flexibility with Custom Modal Types #231

ulusoyca opened this issue Jun 9, 2024 · 1 comment
Assignees
Labels
Custom Modal Type enhancement New feature or request

Comments

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jun 9, 2024

Background

Currently, the WoltModalType class within our package supports a limited array of modal types, specifically bottom sheets and dialogues. While these modal types serve many common use cases, they fall short when more specialized UX designs and interactions are required. Developers often need to implement custom modals that are not only functionally diverse but also seamlessly integrate with existing design systems.

Problem Statement

The existing limitation in the variety of supported modal types and demand for a more flexible modal system that can accommodate a broader range of UI patterns.

Proposed Feature: Customizable Modal Framework

I propose enhancing the WoltModalType class to support the creation and integration of custom modal types. This enhancement would significantly broaden the package's utility, allowing developers to easily implement unique and complex UI patterns.

Feature Description

The introduction of a customizable modal framework would include:

  • Base Custom Modal Class: A base class that provides core functionalities such as animations, positioning, and layout mechanisms. This class would serve as the template from which all specific modal types are derived.
  • Extendible Default Modals: The package should include three fundamental modal types—bottom sheet, dialog, and side sheet. These should be implemented as extensions of the base custom modal class, allowing for straightforward customization. -
  • Developers could modify aspects such as layout, positioning, and transition animations or build entirely new modal types from scratch by extending the WoltModalType class.

Issues Related

Issues related to this feature is labeled with Custom Modal Type

Task list

  • Create abstract WoltModalType for Dialog and Bottomsheet
  • Introduce Side Sheet modal
  • Add modalTypeBuilder to theme data and default theme data
  • Customize transitionDuration for each modal
  • Add useSafeArea to page and WoltModalType
  • Add examples to playground to demonstrate the custom modals.
  • Add fixed wolt modal type for the page.

Example

custom_modal.mov
@ulusoyca ulusoyca added enhancement New feature or request Custom Modal Type labels Jun 9, 2024
@ulusoyca ulusoyca self-assigned this Jun 9, 2024
@ulusoyca ulusoyca pinned this issue Jun 9, 2024
@ulusoyca
Copy link
Collaborator Author

ulusoyca commented Jul 2, 2024

Added in #235

@ulusoyca ulusoyca closed this as completed Jul 2, 2024
@ulusoyca ulusoyca unpinned this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Custom Modal Type enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant