Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make topBarTitle visible all the time #21

Closed
LiLatee opened this issue Jul 20, 2023 · 4 comments
Closed

make topBarTitle visible all the time #21

LiLatee opened this issue Jul 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@LiLatee
Copy link

LiLatee commented Jul 20, 2023

Hi! Great work with the package! 😄
As I understood topBarTitle is only visible when the bottom sheet is scrolled down. Is there a possibility to display topBarTitle all the time and do not use pageTile? 🤔

Here is the example when pageTitle should not be used and topBarTitle should be visible all the time.
image
@ulusoyca
Copy link
Collaborator

This is doable. We will come up with a roadmap for the package development. ping @yunusemrebakir

@ulusoyca ulusoyca added the enhancement New feature or request label Jul 21, 2023
@arbile26
Copy link

I really need something like this.

@ulusoyca ulusoyca moved this to 💡 Proposed in WoltModalSheet Backlog Jul 28, 2023
@ulusoyca ulusoyca moved this from 💡 Proposed to 🎨 Design Review in WoltModalSheet Backlog Jul 28, 2023
@ulusoyca ulusoyca mentioned this issue Aug 6, 2023
Merged
@ulusoyca ulusoyca moved this from 🎨 Needs Design Review to 💬 In review in WoltModalSheet Backlog Aug 6, 2023
@ulusoyca
Copy link
Collaborator

ulusoyca commented Aug 7, 2023

@arbile26 @LiLatee The PR is open. This feature is planning to be landed in next release. Please comment if it answers your use case.
#31

@ulusoyca ulusoyca moved this from 💬 In review to ✅ Done in WoltModalSheet Backlog Aug 7, 2023
@ulusoyca
Copy link
Collaborator

ulusoyca commented Aug 8, 2023

Merged.

@ulusoyca ulusoyca closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
WoltModalSheet Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ulusoyca @LiLatee @arbile26