You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Using accessibility_tools package to check for missing semantic labels, I found that WoltModalSheet.show does not give a semantic label for the dismissible GestureDetector.
It should be possible to add a semantic label to the dismissable GestureDetector, or exclude it from semantics if that information isn't important to a user using TalkBack/VoiceOver
Additional context
The problem seems to be with the GestureDetector in wolt_modal_sheet.dart at line 286
GestureDetector(
behavior:HitTestBehavior.opaque,
onTap: () {
if (widget.route.barrierDismissible) {
final onModalDismissedWithBarrierTap =
widget.onModalDismissedWithBarrierTap;
if (onModalDismissedWithBarrierTap !=null) {
onModalDismissedWithBarrierTap();
} else {
Navigator.of(context).pop();
}
}
},
child:constSizedBox.expand(),
)
The text was updated successfully, but these errors were encountered:
@getBoolean Thanks for the detailed issue. This is an easy fix and should be high priority. Added to the backlog of next release. If you are interested in, feel free to create a PR.
Bug report
Describe the bug
Using accessibility_tools package to check for missing semantic labels, I found that
WoltModalSheet.show
does not give a semantic label for the dismissible GestureDetector.Steps to reproduce
Steps to reproduce the behavior:
WoltModalSheet.show
Code: (click to expand)
Expected behavior
It should be possible to add a semantic label to the dismissable
GestureDetector
, or exclude it from semantics if that information isn't important to a user using TalkBack/VoiceOverAdditional context
The problem seems to be with the
GestureDetector
inwolt_modal_sheet.dart
at line 286The text was updated successfully, but these errors were encountered: