Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adv): validate that advisory IDs are CGA IDs #1350

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

luhring
Copy link
Member

@luhring luhring commented Dec 3, 2024

Before, we were only validating that the ID was a valid vulnerability ID, but not specifically a valid CGA ID.

Example

$ w adv validate
❌ advisory data is not valid.

basic validation failure(s):
    grafana-10.3:
        advisories:
            CVE-2024-28180:
                "CVE-2024-28180" is not a valid CGA ID

cmdpdx
cmdpdx previously approved these changes Dec 3, 2024
@luhring
Copy link
Member Author

luhring commented Dec 3, 2024

Should've checked the other tests that were relying on the looser validation 🤦 I'll clean those up!

@luhring luhring merged commit 3970377 into wolfi-dev:main Dec 10, 2024
3 of 4 checks passed
@luhring luhring deleted the cga-id-validation branch December 10, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants