feat: add services_savingsplans_subscribed metric #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahuel11500
force-pushed
the
feat/add-services-savingsplans-subscribed
branch
from
4c9dfef to
c3a8b64
Compare
|
Local test of the metric with the compose is good with curl 0.0.0.0:8080/metrics | grep "ovh_exporter_services_savingsplans_subscribed" |
maxime1907
reviewed
Feb 19, 2025
|
you forgot to add the routes needed in pkg/credentials/generate |
|
metric is missing some important data like period and flavor |
|
log messages all in lowercase like the rest of the logs |
maxime1907
reviewed
Feb 19, 2025
nahuel11500
force-pushed
the
feat/add-services-savingsplans-subscribed
branch
2 times, most recently
from
1f5877e to
cce9f79
Compare
maxime1907
reviewed
Feb 25, 2025
| "savings_plan_status": savingsPlanStatus, | ||
| "savings_plan_start_date": savingsPlanPeriodStartDate, | ||
| "savings_plan_end_date": savingsPlanPeriodEndDate, | ||
| }).Set(1) |
There was a problem hiding this comment.
put the savingsplan size here instead
|
thanks for the nice documentation! |
maxime1907
reviewed
Feb 25, 2025
README.md
Outdated
| go run cmd/ovh-exporter/main.go credentials | ||
| ``` | ||
|
|
||
| Once you have the credentials, create a `.env` file containing the following variables: |
maxime1907
reviewed
Feb 25, 2025
README.md
Outdated
| @@ -19,14 +28,55 @@ export OVH_CACHE_UPDATE_INTERVAL="300" | |||
| export SERVER_PORT="8080" | |||
| ``` | |||
|
|
|||
| # Running | |||
| To use the compose, add a `.env` file at the root of your project with the variables filled in: | |||
maxime1907
reviewed
Feb 25, 2025
compose.yaml
Outdated
| OVH_CLOUD_PROJECT_INSTANCE_BILLING_PROJECT_IDS: "" | ||
| OVH_CACHE_UPDATE_INTERVAL: "300" | ||
| SERVER_PORT: "8080" | ||
| env_file: ".env" |
maxime1907
reviewed
Feb 25, 2025
compose.yaml
Outdated
| OVH_CACHE_UPDATE_INTERVAL: "300" | ||
| SERVER_PORT: "8080" | ||
| env_file: ".env" | ||
| # OVH_ENDPOINT: "ovh-eu" |
There was a problem hiding this comment.
you can remove these since we explain what should be contained inside the ovh-exporter.env file
nahuel11500
force-pushed
the
feat/add-services-savingsplans-subscribed
branch
from
cce9f79 to
bd39989
Compare
|
Local test successful, maybe we should add some E2E test like in kube-state-metric and a github workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ovh_exporter_services_savingsplans_subscribed metric