Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing default value for operator in waitForElement #148

Open
htho opened this issue Nov 28, 2024 · 0 comments
Open

Missing default value for operator in waitForElement #148

htho opened this issue Nov 28, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@htho
Copy link

htho commented Nov 28, 2024

When there is no operator property in waitForElement there is no output.

Given an input like this:

{
    "type": "waitForElement",
    "target": "main",
    "selectors": [
        "#counter"
    ],
    "count": 1
}

The result is: nothing

The reference says that the default value is ==. So does puppeteer-replay.
BUT The actual behavior is >= .

IMO the behavior should be the same as in Chrome, and therefore default to >=

await expect(browser.$$("#counter")).toBeElementsArrayOfSize({ gte: 1 })
@christian-bromann christian-bromann added the help wanted Extra attention is needed label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants