feat: add a --new option to ssh command

[oneirocosm]

This feature adds a -n or --new flag to the wsh ssh command which allows the connection to open in a new block.

[coderabbitai]

Walkthrough

The changes introduce a new boolean variable newBlock and a corresponding flag --new (or -n) in the SSH command workflow. When executing an SSH connection, if the identifier for an existing terminal block (blockId) is missing and newBlock is false, the process returns an error. If newBlock is true, a new terminal block is created, with metadata such as the connection string encapsulated in a CommandCreateBlockData object, and a method (CreateBlockCommand) is invoked to handle its creation. When newBlock is false, the code instead updates the metadata of the current terminal block using the CommandSetMetaData structure, printing an error message if the update fails.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

cmd/wsh/cmd/wshcmd-ssh.go (2)

42-44: Enhance error message with actionable guidance.

The error message could be more helpful by mentioning the --new flag as a solution.

-		return fmt.Errorf("cannot determine blockid (not in JWT)")
+		return fmt.Errorf("cannot determine blockid (not in JWT). Use --new flag to create a new terminal block")

---

56-77: Add nil check for RpcClient.

While the block creation logic is well-implemented, it's recommended to add a nil check for RpcClient before making the call.

+		if RpcClient == nil {
+			return fmt.Errorf("RPC client not initialized")
+		}
 		oref, err := wshclient.CreateBlockCommand(RpcClient, createBlockData, nil)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b060eb and 7ebfd85.

📒 Files selected for processing (1)

• cmd/wsh/cmd/wshcmd-ssh.go (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)
• GitHub Check: Build for TestDriver.ai

🔇 Additional comments (2)

cmd/wsh/cmd/wshcmd-ssh.go (2)

16-19: LGTM! Clear and well-documented flag addition.

The new --new flag is well-integrated with clear documentation and follows the package's patterns.

Also applies to: 31-31

---

79-91: LGTM! Well-structured block update logic.

The block update logic is well-implemented with proper error handling and clear success messaging.