Improve preview and web widget padding

[esimkowitz]

Removes the padding for most of the specialized previews, moves where it's defined for the directory preview so that the header borders extend to the edge of the block

[coderabbitai]

Walkthrough

The pull request introduces a new optional noPadding property across multiple frontend components, specifically in the PreviewModel and WebViewModel classes. This property is initialized with a default value of true and is of type Atom<boolean>.

Accompanying these class modifications, the CSS file preview.scss has been updated to adjust padding and layout properties. The changes include removing flex-grow: 1; and padding: 0 5px; from the .view-preview class, while adding padding: 5px; to .view-preview-pdf and .view-preview-directory classes.

Additionally, in the StreamingPreview function, the iframe dimensions have been modified from width="95%" height="95%" to width="100%" height="100%", potentially affecting the rendering of PDF previews to occupy the full available space.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

frontend/app/view/webview/webview.tsx (1)

36-36: Document the purpose of the noPadding property.

The newly added noPadding property lacks documentation explaining its purpose and usage.

Add JSDoc comments to explain the property's purpose:

+    /** Controls whether padding should be applied to the webview. */
     noPadding?: Atom<boolean>;

frontend/app/view/preview/preview.tsx (2)

120-120: Document the purpose of the noPadding property.

The newly added noPadding property lacks documentation explaining its purpose and usage.

Add JSDoc comments to explain the property's purpose:

+    /** Controls whether padding should be applied to the preview. */
     noPadding?: Atom<boolean>;

---

437-438: Consider moving the property initialization.

The property initialization is separated from other property initializations by empty lines, affecting code organization.

Move the initialization to be grouped with other property initializations:

-
-        this.noPadding = atom(true);
+        this.noPadding = atom(true);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec07b17 and 336276c.

📒 Files selected for processing (3)

• frontend/app/view/preview/preview.scss (1 hunks)
• frontend/app/view/preview/preview.tsx (3 hunks)
• frontend/app/view/webview/webview.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (go)

🔇 Additional comments (3)

frontend/app/view/webview/webview.tsx (1)

62-62: Verify the usage of the noPadding property.

The noPadding property is initialized but not utilized in the component's rendering or styling logic.

frontend/app/view/preview/preview.tsx (1)

831-831: LGTM! Improved iframe dimensions.

The change from 95% to 100% dimensions improves space utilization and aligns with the padding adjustments in the SCSS file.

frontend/app/view/preview/preview.scss (1)

44-47: LGTM! Consistent padding for PDF and directory views.

The addition of consistent padding improves the visual presentation and aligns with the iframe dimension changes.