Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory growth does not appear to be supported in Go #52

Closed
fproulx-dfuse opened this issue Jun 24, 2019 · 1 comment · Fixed by #55
Closed

Memory growth does not appear to be supported in Go #52

fproulx-dfuse opened this issue Jun 24, 2019 · 1 comment · Fixed by #55
Assignees
@Hywan
Labels
📦 component-extension About the Go extension 🎉 enhancement New feature or request

Comments

@fproulx-dfuse
Copy link

Motivation

Right now in Go, we get a Memory, but it's not clear how many pages it gets and there is no way to manage (grow) it dynamically.

Proposed solution

Rust lib has wasmer_memory_grow which is already linked, but not exposed in Go binding.
@fproulx-dfuse fproulx-dfuse added the 🎉 enhancement New feature or request label Jun 24, 2019
@Hywan Hywan self-assigned this Jun 25, 2019
@Hywan Hywan added the 📦 component-extension About the Go extension label Jun 25, 2019
@Hywan
Copy link
Contributor

Hywan commented Jun 25, 2019

Yup, we can add it. PR are welcome, or wait few days I make it :-).

@Hywan Hywan mentioned this issue Jul 8, 2019
Merged
bors bot added a commit that referenced this issue Jul 8, 2019
@bors @Hywan
Merge #55
f819ba8 
55: feat(memory) Add the `Memory.Grow` method r=Hywan a=Hywan

Fix #52.

This method can be used to grow the memory by a number of pages (65kb each).

Co-authored-by: Ivan Enderlin <[email protected]>
@bors bors bot closed this as completed in #55 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hywan Hywan

Labels
📦 component-extension About the Go extension 🎉 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(memory) Add the Memory.Grow method Hywan/go-ext-wasm
2 participants
@Hywan @fproulx-dfuse