-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme assets missing in MPA mode #1401
Comments
Yeah I'd noticed this earlier too (#848 (comment)). But considering the default theme is mostly broken too without client js, I don't think MPA can ever be fully supported. |
Yeah... I think we should document this when we add |
Docs are updated: https://vitepress.dev/guide/mpa-mode, but still thinks that assets needs to be properly resolved (shouldn't be related to JS, somewhere the logic is wrong IG) |
I am also having this issue. Any chance this can be fixed? |
Describe the bug
When using
img src=../static/image.png
with--mpa
, the assets don't make it to the output.Reproduction
Build a theme component like
And an image in
.vitepress/theme/static/logo.svg
.Run
vitepress build
.Expected behavior
That
.vitepress/dist/assets/logo.XXXXXX.svg
is present after build.System Info
Additional context
Changing
bundle()
so it runsbuild(resolveViteConfig(false)
even in MPA mode brings the theme assets over.(What I'm after is a mode that doesn't include the sitemap on every HTML page. I'm happy to run JS in the client. Was just playing with MPA to see if that would help.)
Validations
The text was updated successfully, but these errors were encountered: