Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for zone-redundant storage (ZRS) managed disks #4608

Closed
volver-13 opened this issue Jan 31, 2022 · 2 comments
Closed

Support for zone-redundant storage (ZRS) managed disks #4608

volver-13 opened this issue Jan 31, 2022 · 2 comments

Comments

@volver-13
Copy link

Describe the problem/challenge you have
Velero is currently unable to backup and restore Azure Zone Redundant Disks introduced at March 02, 2021: Zone Redundant Storage

When it tries to backup ZRS volume the following error is thrown:

time="2022-01-25T16:55:34Z" level=info msg="1 errors encountered backup up item" backup=velero/newbackup5 logSource="pkg/backup/backup.go:412" name=nginx-deployment-ccb85775c-ws7r7
time="2022-01-25T16:55:34Z" level=error msg="Error backing up item" backup=velero/newbackup5 error="error getting volume info: rpc error: code = Unknown desc = disk has a nil SKU" logSource="pkg/backup/backup.go:416" name=nginx-deployment-ccb85775c-ws7r7

Looks like velero-plugin-for-microsoft-azure plugin uses some old Azure SDK version.

ZRS disk types are NOT present on the DiskStorageAccountTypes enum in 2019-07-01 SDK

Newest 2021-11-01 SDK contains ZRS types on the list.

Possibly easy win to add support for ZRS disks?

Describe the solution you'd like
it would be great if velero would be able to snapshot ZRS disks and be able to restore them

Environment:

I tried the lastest:

velero/velero:v1.8.0-rc.1
velero/velero-plugin-for-microsoft-azure:v1.4.0-rc.1

in AKS 1.21.7

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@ywk253100
Copy link
Contributor

Should be fixed by vmware-tanzu/velero-plugin-for-microsoft-azure#131

@yyvess
Copy link

yyvess commented Apr 12, 2022

@ywk253100 Still an issue with ZRS volume during the restore.
Disks are always created with a Zone specified but for ZRS volume the Zone must not be set other this error is raise :
rpc error: code = Unknown desc = compute.DisksClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="OperationNotAllowed" Message="A disk with sku 'StandardSSD_ZRS' cannot be created in an availability zone

I have prepared a PR to fix it =>
vmware-tanzu/velero-plugin-for-microsoft-azure#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants