Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Core] Support tensor parallelism with uneven heads #13934

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yixqiao
Copy link

@yixqiao yixqiao commented Feb 26, 2025

Currently working on supporting tensor parallelism when using attention heads that do not divide the number of GPUs evenly, for example with Qwen2.

Using a dummy head approach to pad to an even number. Currently testing with Qwen2 1.5B with 12 heads on 8 GPUs (so 4 dummy heads).

Works end to end, but has poor results.
Prompt: "This is a brief introduction to large language models. Large language models (LLMs) are"
vLLM non-parallel reference: "particularly useful language model techniques to interact with language models, so as to compress a"
New feature (this PR): "10 instructions in deleting newton's law of relational networks. Common utility."

Working on debugging the accuracy issue now.

FIX #11797

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented Feb 26, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @yixqiao.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: prototype a support for non divisible attention heads
1 participant