Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller embedding model when not testing model specifically #13891

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hmellor
Copy link
Collaborator

@hmellor hmellor commented Feb 26, 2025

Replaces:

This reduction in parameters is 560M & 7B -> 118M.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 26, 2025
@DarkLight1337
Copy link
Member

Let's update vllm/test_utils.py accordingly as well.

@DarkLight1337
Copy link
Member

cc @khluu can you add this model to S3?

@hmellor
Copy link
Collaborator Author

hmellor commented Feb 26, 2025

@CatherineSue I just wanted to check with you that I've not changed anything that will significantly reduce the coverage of Mistral embedding models?

@hmellor
Copy link
Collaborator Author

hmellor commented Feb 26, 2025

cc @khluu can you add this model to S3?

We're likely about to switch to EFS so no need to upload to S3

@hmellor hmellor requested a review from ywang96 as a code owner February 26, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants