Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook framework #748

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

kerthcet
Copy link
Collaborator

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

xref: #710
copy of #713

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

Signed-off-by: kerthcet <[email protected]>
@kerthcet kerthcet mentioned this pull request Feb 26, 2025
@kerthcet kerthcet requested a review from Jeffwan February 26, 2025 06:22
@kerthcet
Copy link
Collaborator Author

wait a minute, seems I didn't revert back the manifest cmd.

@kerthcet
Copy link
Collaborator Author

Finished, PTAL @Jeffwan

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 26, 2025

The change looks good to me. I've reviewed it in earlier closed PR. Great and we have webhook now!

@Jeffwan Jeffwan merged commit 1b2fe77 into vllm-project:main Feb 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants