Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Minor refactor the PodAutoscaler codes #68

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Aug 1, 2024

Pull Request Description

  1. I add some TODOs
  2. remove v(3). log level. Let's be consistent and make sure it's either empty level or V(4)
  3. Resolve some naming issues
  4. Update crd and add conditions to follow up

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan requested a review from kr11 August 1, 2024 01:15
@Jeffwan Jeffwan force-pushed the jiaxin/minor-improvement-pod-autoscaler branch from 063448d to 233e5f4 Compare August 1, 2024 05:12
@kr11
Copy link
Collaborator

kr11 commented Aug 1, 2024

looks good to me.

@Jeffwan Jeffwan merged commit 744a29a into main Aug 1, 2024
@Jeffwan Jeffwan deleted the jiaxin/minor-improvement-pod-autoscaler branch August 1, 2024 06:43
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* [Misc] Minor refactor the PodAutoscaler codes

* Resolve code review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants