fix(css): track dependencies from addWatchFile for HMR #15608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the module-graph/HMR handling code in the
cssPlugin
, to a newcssAnalysisPlugin
, which is placed at the end like import analysis. This waythis.addWatchFile
calls from plugins that transform the CSS will work and update appropriately.This is helpful for SFC files like Vue/Svelte/Astro where the file is internally transformed into JS that imports the scoped CSS virtual module. And since they already pre-processed the CSS with dependencies, they can assign those dependencies to the CSS virtual modules directly. Today, the only workaround is to add the dependencies to the SFC file, which isn't accurate.
Additional context
Working on improving Astro's CSS HMR: withastro/astro#9370 😬
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).