Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): set js loader for build transpile #14980

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 14, 2023

Description

fix #10147

Since renderChunk should always only deal with JS files, we can set loader: 'js' as an optimization, and also fix #10147 so it doesn't have to detect the extension manually.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 14, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be accepting not having a .js extension for chunks as a feature after merging this PR, and maybe we should keep it more strict. I like this as an optimization though. We aren't documenting a change so lets merge the PR, we could later still decide to force a js extension if we have good reasons to do it.

@patak-dev patak-dev merged commit 80beede into main Nov 14, 2023
@patak-dev patak-dev deleted the fix-esbuild-transpile-loader branch November 14, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build] - esbuild Invalid loader value error when using chunkFileNames options
2 participants