Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(client): overlay frame show scrollbar #14701

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Oct 19, 2023

Description

When the page displays an error message pop-up window, if the content is too long, it is more friendly to display a scrollbar.

image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea
Copy link
Collaborator Author

btea commented Nov 11, 2023

@bluwy Do you think this change is necessary?

@bluwy
Copy link
Member

bluwy commented Nov 11, 2023

Personally, I don't really know 😄 But it doesn't hurt to add a scrollbar so I'm going to approve this as see what others think. It's only showing when there's long content so I think it's fine.

bluwy
bluwy previously approved these changes Nov 11, 2023
@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 14, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion but I think we can have this.

@patak-dev patak-dev merged commit 8aa4134 into vitejs:main Nov 14, 2023
@btea btea deleted the feat/overlay-frame-add-scrollbar branch November 15, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants