-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(optimizer): limit bundled file name length to 170 characters #14561
Conversation
I made the "longfilename/aa...aa/aa...aa" file 181 characters. I suits the purpose of this fix and does not cause error on windows environment. |
I added a test that actually checks the length of the file name. And I added the unit test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean!
Description
closes #14542
I limited the dependent file name to 170 characters. Preserving first
159161 characters followed by an underscore and first108 characters of its hash, i.e."very/long/filenameeee...e_abcde12345"
"very/long/filenameeee...e_abcd1234"
.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).