Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmojiOne regression? #259

Closed
stefanhaustein opened this issue Feb 25, 2018 · 5 comments
Closed

EmojiOne regression? #259

stefanhaustein opened this issue Feb 25, 2018 · 5 comments

Comments

@stefanhaustein
Copy link
Contributor

Hi, could there be a recent regression in 6.0-SNAPSHOT wrt. EmojiOne images? Several Emoji seem to be missing (boxed button-like arrows, skull&bones), and the Emoji look like EmojiOne 2 (opposed to EmojiOne 3)?

Perhaps related to the recent change to sprite sheets?

I'd revert to 5.1 for now, but I can't because that pulls in an older version of the design or support library...

@vanniktech
Copy link
Owner

You can override the versionf of design + support library. As for the missing images, I'd refer to @rubengees

@rubengees
Copy link
Collaborator

@stefanhaustein You are right, did not notice that while testing as I am not using EmojiOne in any of my apps. We are now using this data source which does not not have the latest EmojiOne emojis and there is already an open issue + open PR for that, so you can watch those for updates if you like.

If you want to use the previous version without going all the way back to 0.5.1, you can use this dependency from JitPack: com.github.vanniktech:Emoji:7f7f35c3e7

@stefanhaustein
Copy link
Contributor Author

Thanks, compile 'com.github.vanniktech.Emoji:emoji-one:7f7f35c3e7' seems to work for now....

@vanniktech
Copy link
Owner

@rubengees we could update everything now again, right? The PR on emojione was merged.

@rubengees
Copy link
Collaborator

@vanniktech Yes! I'll try to find time to do that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants