-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center Emoji in line #121
Comments
I don't think you'll need to do anything in order to let it be centered. Maybe the line spacing is causing this dropping down effect. |
How can i fix this then? |
Can you try |
Interesting. Maybe support for those attributes have to be added too. |
Might I suggest you leave both options in there? So if size is undefined it used the line height otherwise the emoji size? I don't think line height will ever look right if changed, since it's all below the text. And I assume most people would want either centered or bottom aligned. |
So using |
I think that would be the best of both worlds. |
@justmobilize would you like to submit a PR? |
@vanniktech how can i include this update into my gradle files? |
Use the maven snapshot url and use |
Unfortunately SNAPSHOT version has problems. When you leave the app and re-open it, the text box height becomes 0 and emojies vanish. Also emoji size has no effect still. |
Which approach are you using? |
Hmm what does your xml layout declaration / java code look like? Try out the sample and just send an Emoji. In there it does work. |
Actually it works on Emulator with no problem! And if I change no non SNAPSHOT version then it would be fine but the emoji keyboard not closing on back press happens! <com.vanniktech.emoji.EmojiTextView The code is exactly as your sample. I haven't add anything special. |
Maybe the |
Let me check more. The weird thing is that it doesn't have any problem in the emulator. Also if you remember in issue #138 and Ereza mentioned the same problem of line height becoming 0 and he thought he resolved it with removing the emoji size but it was not solved apparently. |
Yup I do. I also yesterday briefly experimented with displaying the emoji in a bigger size when you only send one (similary to what Whatsapp & Slack does) and I also stumbled upon some problems. I definitely want this to get fixed before doing |
That would be great if it's fixed soon. We plan to release and use your library in end of July so we would be really happy if it's fixed. But I will try to go around and test different cases to see if it's possible to fix it. |
I'd fix it right away if the project I'm working on would require this library. Unfortunately priorities have changed recently and it's a complete side project. I also created #148 for further discussion about the Emoji size potential. |
Excellent, we really appreciate your great work. Good luck. |
I can also look into some of this. We are a handful of commits back (before the sizing started to change) and resizing single emojis (without text works). |
I'd appreciate any help. I'm also waiting with |
Hi,
is it somehow possible to center an emoji in its line?
I manually set the lineheight via
emojiTextView.setLineSpacing(0f, 1.5f);
Unfortunately the emoji "drops" and is not displayed centered.
I could not find any method in your files to do this.
If there is none could you add this in a future release please?
With kind regards,
Sebastian Schneider
The text was updated successfully, but these errors were encountered: