* [Issue #4] Bug in the implementation of Api.getApps() leading to users with id 0 getting ignored.

amaa-99 · amaa-99 · commit 3fc3b49d48c9 · 2023-07-25T17:47:37.000+02:00
Fixed a bug in the implementation of Api.getApps() leading to users with id 0 getting ignored and subsequently to the returned apps list being empty.
diff --git a/app/src/main/java/dev/ukanth/ufirewall/Api.java b/app/src/main/java/dev/ukanth/ufirewall/Api.java
@@ -1422,7 +1422,7 @@ public static List<PackageInfoData> getApps(Context ctx, GetAppList appList) {
                 Matcher m = p.matcher(user.toString());
                 if (m.find() && m.groupCount() > 0) {
                     int id = Integer.parseInt(m.group(1));
-                    if (id > 0) {
+                    if (id >= 0) {
                         listOfUids.add(id);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -1422,7 +1422,7 @@ public static List<PackageInfoData> getApps(Context ctx, GetAppList appList) {`
`1422`	`1422`	`Matcher m = p.matcher(user.toString());`
`1423`	`1423`	`if (m.find() && m.groupCount() > 0) {`
`1424`	`1424`	`int id = Integer.parseInt(m.group(1));`
`1425`		`- if (id > 0) {`
	`1425`	`+ if (id >= 0) {`
`1426`	`1426`	`listOfUids.add(id);`
`1427`	`1427`	`}`
`1428`	`1428`	`}`